[Webkit-unassigned] [Bug 149056] [GTK] Spellchecker rejects word when adding a period character if there is no trailing space before the next word

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 12 13:53:49 PST 2016


https://bugs.webkit.org/show_bug.cgi?id=149056

Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #271148|review?, commit-queue?      |review-
              Flags|                            |

--- Comment #9 from Martin Robinson <mrobinson at webkit.org> ---
Comment on attachment 271148
  --> https://bugs.webkit.org/attachment.cgi?id=271148
Check every parts of words containing periods or colons.

View in context: https://bugs.webkit.org/attachment.cgi?id=271148&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

I think this change deserves a test.

> Source/WebCore/ChangeLog:17
> +        - or Swedish and Finnish words containing a colon.

I think we need to understand why this is a problem for Enchant and not for the Mac port. If it is a problem for the Mac port, we likely need to do this fix at a higher level. We should compare the behavior of the GTK+ port to Safari.

> Source/WebCore/platform/text/enchant/TextCheckerEnchant.cpp:-102
>      int start = textBreakFirst(iter);
>      for (int end = textBreakNext(iter); end != TextBreakDone; end = textBreakNext(iter)) {
>          if (isWordTextBreak(iter)) {
> -            checkSpellingOfWord(utf8String, start, end, misspellingLocation, misspellingLength);

Why isn't wordBreakIterator breaking on the punctuation already? I think that understanding the context of the problem is important to reviewing the patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160212/7e251b81/attachment.html>


More information about the webkit-unassigned mailing list