[Webkit-unassigned] [Bug 144717] Web Inspector: Tabs: Conflicts with multiple Formatters per SourceCode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144717

--- Comment #10 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 271128
  --> https://bugs.webkit.org/attachment.cgi?id=271128
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=271128&action=review

>> Source/WebInspectorUI/UserInterface/Views/ContentView.js:68
>> +    static _finalRepresentedObjectForRepresentedObject(representedObject)
> 
> The '_final' terminology is confusing to me. Can we call it 'resolved' or 'displayable' or something like that? When reading it as 'finalRepresentedObject' i had the impression that it was being mutated or something.

I like resolved.

> Source/WebInspectorUI/UserInterface/Views/ContentView.js:84
> +            else if (representedObject.sourceCode instanceof WebInspector.Script)

No else.

> Source/WebInspectorUI/UserInterface/Views/ContentViewContainer.js:423
> +        console.assert(!contentView.__tombstoneContentViewContainers || !contentView.__tombstoneContentViewContainers.includes(this));

Why not a symbol?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160212/261fd670/attachment.html>