[Webkit-unassigned] [Bug 154127] Soft spaces are often tracked in the wrong spot

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154127

Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #271088|review?                     |review+
              Flags|                            |

--- Comment #5 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 271088
  --> https://bugs.webkit.org/attachment.cgi?id=271088
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271088&action=review

Please do the refactor we discussed so we don't have the duplicated code.  Also, please file a follow up bug to add the test infrastructure for testing this.

> Source/WebKit2/UIProcess/WebPageProxy.cpp:5819
> +    process().send(Messages::WebPage::InsertTextAsync(text, replacementRange, registerUndoGroup, (uint32_t)editingRangeIsRelativeTo), m_pageID);

static_cast please.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:4334
> +        RefPtr<Range> replacementRange = rangeFromEditingRange(frame, replacementEditingRange, (EditingRangeIsRelativeTo)editingRangeIsRelativeTo);

static_cast

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160211/928f7881/attachment.html>