[Webkit-unassigned] [Bug 154074] [cmake] Consolidate CMake code related to image decoders.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 10 11:09:25 PST 2016


--- Comment #7 from Alex Christensen <achristensen at apple.com> ---
(In reply to comment #6)
> Comment on attachment 270993 [details]
> Patch
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=270993&action=review
> >>> Source/WebCore/ImageDecoders.cmake:29
> >>> +if (JPEG_FOUND)
> >> 
> >> I think these should remain unconditional.  We should have a hard failure if these aren't found.
> > 
> > WinCairo does not use find_package for libjpeg and libpng, therefore repspective variables are empty. I thought it is not a good practice to append empty variables to the lists.
> BTW, hard failure is guaranteed by REQUIRED flag, set by ports in
> Options*.cmake when find_package is invoked.
And JPEGImageDecoder.cpp is compiled unconditionally, so it won't link successfully if there is no library.  I guess these if (*_FOUND) checks are ok.

Just move the file to platform, then.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160210/5eaa8659/attachment.html>

More information about the webkit-unassigned mailing list