[Webkit-unassigned] [Bug 149742] Regression: Web Inspector: Sometimes in Elements panel two elements showed as selected at the same time

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 9 21:15:25 PST 2016


--- Comment #10 from Joseph Pecoraro <joepeck at webkit.org> ---
> However I'm marking as cq- because I still fail to see how this was caused
> by r187496, which means there is something I don't yet fully understand
> here, so I want to investigate this a bit more.

I now understand!

The same optimization that I'm adding to moveChild(...) effectively happened before. While iterating over the child list the old code would skip over tree elements in the correct place:

>    while (child) {
>        var currentTreeElement = treeElement.children[treeChildIndex];
>        if (!currentTreeElement || currentTreeElement.representedObject !== child) {
>            ...
>        }
>        ...
>    }

Basically we now do that first check in moveChild(...). The old code could presumably have a bug that this addresses with the correct selecting.

Either way, I'm now confident that this can land.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160210/541b15d0/attachment-0001.html>

More information about the webkit-unassigned mailing list