[Webkit-unassigned] [Bug 153939] AX: Implement word related text marker functions using TextIterator

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153939

chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #270951|review?                     |review+
              Flags|                            |

--- Comment #14 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 270951
  --> https://bugs.webkit.org/attachment.cgi?id=270951
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270951&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:1568
> +    return AccessibilityObject::replacedNodeNeedsCharacter(node) || node->hasTagName(brTag);

you can probably make this into one line

return node && ...

> Source/WebCore/accessibility/AXObjectCache.cpp:1724
> +        CharacterOffset co = CharacterOffset();

i would change co -> charOffset

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:4078
> +        CharacterOffset characterOffset = [self characterOffsetForTextMarker:textMarker];

you can move the characterOffset creation after the check for the cache, since it's not needed until then

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160209/57e887f0/attachment.html>