[Webkit-unassigned] [Bug 154007] [GTK] Toggle buttons are blurry with GTK+ 3.19

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154007

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #270923|review?                     |review+
              Flags|                            |

--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 270923
  --> https://bugs.webkit.org/attachment.cgi?id=270923
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270923&action=review

Thanks, I presume you tested it.

> Source/WebCore/rendering/RenderThemeGtk.cpp:551
> +    gtk_style_context_get(childContext.get(), gtk_style_context_get_state (childContext.get()), "min-width", &minWidth, "min-height", &minHeight, nullptr);

Look what style checker caught: gtk_style_context_get_state (

> Source/WebCore/rendering/RenderThemeGtk.cpp:555
> +        minSize.setHeight(minHeight);

Company's suggestion was to do this:

if (minWidth && minHeight) {
    minSize.setWidth(minWidth);
    minSize.setHeight(minHeight);
}

Any particular reason for not following that?

> Source/WebCore/rendering/RenderThemeGtk.cpp:598
> +    gtk_style_context_get(context.get(), gtk_style_context_get_state (context.get()), "min-width", &minWidth, "min-height", &minHeight, nullptr);

Ditto

> Source/WebCore/rendering/RenderThemeGtk.cpp:602
> +        minSize.setHeight(minHeight);

Ditto

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160209/74fde88e/attachment.html>