[Webkit-unassigned] [Bug 153998] New: check-webkit-style cannot check parameters with macros

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 8 12:05:55 PST 2016


https://bugs.webkit.org/show_bug.cgi?id=153998

            Bug ID: 153998
           Summary: check-webkit-style cannot check parameters with macros
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: jiewen_tan at apple.com
                CC: lforschler at apple.com

For a method defined as below:
MouseEvent::MouseEvent(const AtomicString& eventType, bool canBubble, bool cancelable, AbstractView* view, int detail, int screenX, int screenY, int clientX, int clientY, bool ctrlKey, bool altKey, bool shiftKey, bool metaKey, unsigned short button, PassRefPtr<EventTarget> relatedTarget)
    : MouseRelatedEvent(eventType, canBubble, cancelable, WTF::currentTime(), view, detail, IntPoint(screenX, screenY), IntPoint(0, 0), //L135
#if ENABLE(POINTER_LOCK)
        IntPoint(0, 0), //L137
#endif
        ctrlKey, altKey, shiftKey, metaKey, false)
    , m_button(button == (unsigned short)-1 ? 0 : button)
    , m_buttonDown(button != (unsigned short)-1)
    , m_relatedTarget(relatedTarget)
{
    initCoordinates(IntPoint(clientX, clientY));
}

check-webkit-style will complains:
ERROR: Source/WebCore/dom/MouseEvent.cpp:135:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/dom/MouseEvent.cpp:137:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]

Refer to Bug 153903.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160208/212024c4/attachment.html>


More information about the webkit-unassigned mailing list