[Webkit-unassigned] [Bug 153951] "ref test hashes didn't match but diff passed" is useless, should not be logged

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 7 12:19:32 PST 2016


--- Comment #5 from Alexey Proskuryakov <ap at webkit.org> ---
> I think that the following should do it (untested):

That doesn't work for reftests, will attach a patch that does.

Now that I have a build on this machine, and ran the tests, I only got 14 failures out of these 20. I got:

- many that look like color management issues;

- some antialiasing differences;

- and several that I cannot easily categorize;

- no size failures, so I'd like to know what hardware/OS combination you got these on (also WebKit1 or WebKit2, which could be seen in complete run-webkit-tests output).

The other 4 failures that you got could be specific to your hardware, in which case they need to be reported internally at Apple.

I do not think that hiding these messages would be the right answer. We should work to get these failures down to zero, yet even now, one can and should use them to detect regressions in their patches (see e.g. Dave's request in bug 69444).

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160207/0a078b52/attachment.html>

More information about the webkit-unassigned mailing list