[Webkit-unassigned] [Bug 153958] New: Refactor NetscapePluginX11 constructors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153958

            Bug ID: 153958
           Summary: Refactor NetscapePluginX11 constructors
    Classification: Unclassified
           Product: WebKit
           Version: Other
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Plug-ins
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at igalia.com

We should fix this warning:

../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:67:14: warning: private field 'm_windowID' is not used [-Wunused-private-field]
    uint64_t m_windowID { 0 };
             ^

It's not trivial though, because we have an extra constructor to assign this via a parameter, so we should remove that parameter. But then we wind up with two different constructors with the same parameter list. Someone familiar with the code should take a look.

I also do not like that we have a static create function but also public constructors. The class is not refcounted, so I don't see value in the create function.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160207/d89d68d3/attachment.html>