[Webkit-unassigned] [Bug 153951] New: "ref test hashes didn't match but diff passed" is useless, should not be logged

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153951

            Bug ID: 153951
           Summary: "ref test hashes didn't match but diff passed" is
                    useless, should not be logged
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Local Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: darin at apple.com
                CC: lforschler at apple.com

When I run tests, I see output like this:

  compositing/hidpi-compositing-vs-non-compositing-check-on-testing-framework.html -> ref test hashes didn't match but diff passed
  compositing/masks/compositing-clip-path.html -> ref test hashes didn't match but diff passed
  compositing/overlap-blending/children-opacity-huge.html -> ref test hashes didn't match but diff passed
  compositing/overlap-blending/children-opacity-no-overlap.html -> ref test hashes didn't match but diff passed
  compositing/overlap-blending/nested-non-overlap-clipping.html -> ref test hashes didn't match but diff passed
  compositing/transitions/transform-on-large-layer.html -> ref test hashes didn't match but diff passed  
  compositing/video/poster.html -> ref test hashes didn't match but diff passed 
  fast/borders/border-image-fill-no-border.html -> ref test hashes didn't match but diff passed                              
  fast/css/object-fit/object-fit-canvas.html -> ref test hashes didn't match but diff passed                                    
  fast/css/sticky/sticky-left-percentage.html -> ref test hashes didn't match but diff passed
  fast/images/animated-gif-no-layout.html -> ref test hashes didn't match but diff passed
  fast/images/gif-loop-count.html -> ref test hashes didn't match but diff passed 
  fast/images/pdf-as-image-crop-box.html -> ref test hashes didn't match but diff passed        
  fast/regions/overflow/overflow-size-change-with-stacking-context-rtl.html -> ref test hashes didn't match but diff passed
  imported/w3c/css/css-color-3/t424-hsl-basic-a.xht -> ref test hashes didn't match but diff passed                                       
  imported/w3c/css/css-color-3/t424-hsl-parsing-f.xht -> ref test hashes didn't match but diff passed
  imported/w3c/css/css-color-3/t425-hsla-parsing-f.xht -> ref test hashes didn't match but diff passed                               
  imported/mozilla/svg/text/textpath-selection.svg -> ref test hashes didn't match but diff passed
  svg/canvas/canvas-global-alpha-svg.html -> ref test hashes didn't match but diff passed
  svg/repaint/buffered-rendering-static-image.html -> ref test hashes didn't match but diff passed                                          

This information is all useless to me, and to anyone, I think.

If these were pixel tests, then I suppose someone might want to know that the tests are matching on disk, but the hash isn’t matching, so they can regenerate images with correct hashes for faster test running in the future. But for a reference test, who is this message for? What is the action needed here?

We should not contaminate the output with these logs, unless there is some real world project we will do that makes use of them.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160206/90473060/attachment.html>