[Webkit-unassigned] [Bug 153903] New: Rename *Event::create* which creates events for bindings to *Event::createForBindings* and cleanup corresponding paths

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 4 17:13:00 PST 2016


https://bugs.webkit.org/show_bug.cgi?id=153903

            Bug ID: 153903
           Summary: Rename *Event::create* which creates events for
                    bindings to *Event::createForBindings* and cleanup
                    corresponding paths
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Event Handling
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: jiewen_tan at apple.com

Rename Event::create(const AtomicString& type, const EventInit& initializer) to Event::createForBindings(const AtomicString& type, const EventInit& initializer) and for all the subclasses as well in order to support Event.isTrusted. Since this one is the DOM API, the isTrusted flag will be unset here using the Event(const AtomicString& type, const EventInit&) constructor in the following patch Bug 76121. Correspondingly, Event::create(const AtomicString& type, bool canBubble, bool cancelable) will set the isTrusted flag. From my inspection, some of the subclasses such as MediaKeyEvent* and UIEventWithKeyState* will use DOM API for C++ code path as well. Therefore, besides renaming, this patch will also cleanup the path. What's more, there is another Event::create() method. This one needs to be rename to Event::createForBindings() as well and a path cleanup. For legacy content, it is combined with Event::initEvent to create an event for bindings.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160205/c2f344a7/attachment-0001.html>


More information about the webkit-unassigned mailing list