[Webkit-unassigned] [Bug 153835] [WTR] Crash in EventSendingController::contextClick() when context menu event is not handled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153835

Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #270583|review?                     |review+
              Flags|                            |

--- Comment #2 from Martin Robinson <mrobinson at webkit.org> ---
Comment on attachment 270583
  --> https://bugs.webkit.org/attachment.cgi?id=270583
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270583&action=review

> Tools/ChangeLog:9
> +        the context menu event is not hanlded, but we are using the

Nit: hanlded -> handled

> Tools/WebKitTestRunner/InjectedBundle/EventSendingController.cpp:558
> -    size_t entriesSize = WKArrayGetSize(menuEntries.get());
> +    size_t entriesSize = menuEntries ? WKArrayGetSize(menuEntries.get()) : 0;

Perhaps better to simply return early in this case?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160203/f05a0976/attachment-0001.html>