[Webkit-unassigned] [Bug 153799] [JSC] Implement Object.getOwnPropertyDescriptors() proposal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 2 18:13:54 PST 2016


https://bugs.webkit.org/show_bug.cgi?id=153799

--- Comment #16 from Caitlin Potter (:caitp) <caitp at igalia.com> ---
Comment on attachment 270524
  --> https://bugs.webkit.org/attachment.cgi?id=270524
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270524&action=review

>> Source/JavaScriptCore/ChangeLog:21
>> +        (testPrototypeProperties.F):
> 
> Not a great change log. Would be nice to write comments here and remove the lists of function names where they aren’t helpful.

Done

>> Source/JavaScriptCore/runtime/ObjectConstructor.cpp:261
>> +        const Identifier& propertyName = *it;
> 
> Should use a modern for loop:
> 
>     for (auto& propertyName : properties) {

Done

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160203/7e30fae5/attachment.html>


More information about the webkit-unassigned mailing list