[Webkit-unassigned] [Bug 153554] [webkitdirs] Clarify logic behind is{PortName} functions.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153554

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #270498|review?                     |review+
              Flags|                            |

--- Comment #27 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 270498
  --> https://bugs.webkit.org/attachment.cgi?id=270498
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270498&action=review

> Tools/Scripts/webkitdirs.pm:101
> +    Efl      => "Efl",

Shouldn't it be EFL in all caps?

> Tools/Scripts/webkitdirs.pm:2113
> +    return ucfirst portName();

To make sure we have PlatformIOS and OptionsIOS rather than PlatformiOS and OptionsiOS? Good thinking.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160202/1982b09d/attachment.html>