[Webkit-unassigned] [Bug 153554] [webkitdirs] Clarify logic behind is{PortName} functions.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153554

--- Comment #25 from Konstantin Tokarev <annulen at yandex.ru> ---
Comment on attachment 270213
  --> https://bugs.webkit.org/attachment.cgi?id=270213
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270213&action=review

>>> Tools/Scripts/build-jsc:86
>>> +    die "Please choose which WebKit port to build";
>> 
>> It would be good to list available ports and show how to select the port. For example:
>> 
>> "Please specify which WebKit port to build with --efl or --gtk."
>> 
>> This only matters for Linux, since other platforms have default ports.
>> 
>> This could could be shared between build-jsc, build-webkit, and also run-minibrowser (which currently prints an extraordinarily confusing warning that the platform is not supported unless you magically know to pass --efl or --gtk).
> 
> It’s slightly more idiomatic perl to write:
> 
>     die "Please specify which WebKit port to build with --efl or --gtk." if $isUnknownPort();

Done, run-minibrowser now dies in the same manner.

>> Tools/Scripts/build-webkit:142
>> +}
> 
> Ditto.
> 
> Quite annoying that this needs to be repeated in two separate scripts. Please find a way to avoid that.

Done.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160202/5d86637a/attachment.html>