[Webkit-unassigned] [Bug 136916] Pending API request URL no set when loading Alternate HTML or plain text

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 2 03:33:56 PST 2016


https://bugs.webkit.org/show_bug.cgi?id=136916

--- Comment #15 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #12)
> Comment on attachment 243974 [details]
> Now also including the xcode file changes
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=243974&action=review
> 
> I’m saying review+ but I’d still like to understand if Anders agrees about
> this use of "about:blank".
> 
> > Source/WebKit2/UIProcess/WebPageProxy.cpp:860
> > +    auto transaction = m_pageLoadState.transaction();
> > +    m_pageLoadState.setPendingAPIRequestURL(transaction, ASCIILiteral("about:blank"));
> 
> I think it’s a little peculiar to actually set the URL to about::blank here.
> Do we agree that explicitly giving it this particular URL makes sense? Does
> WebKit already treat this as if it came from that URL in other ways or is
> that a new concept we are introducing? If WebKit does already use this URL
> then why are we having to inject it specifically here?
> 
> I think this would read better without the local variable even though the
> other function does have it in a local variable since it uses it twice. I
> think blankURL().string() is better than ASCIILiteral("about:blank").
> 
>     m_pageLoadState.setPendingAPIRequestURL(m_pageLoadState.transaction(),
> blankURL().string());

The local variable is not because it's reused, but because we want the transaction to be finished when the function goes out of scope, the transaction destructor is the one committing the changes to the page load state.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160202/7b0a1bf5/attachment.html>


More information about the webkit-unassigned mailing list