[Webkit-unassigned] [Bug 153624] Add code to parse the git branches out of the Trac RSS feed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153624

--- Comment #5 from Jason Marcell <jmarcell at apple.com> ---
(In reply to comment #2)
> Comment on attachment 270165 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=270165&action=review
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:69
> > +            return (!commit.containsBranchLocation || commit.branchName === branchName || (commit.branchName instanceof Array && commit.branchName.includes(branchName))) && filter(commit);
> 
> This does not seem like the correct approach. In particular, its weird that
> branchName could be either a String object or an Array object.

I addressed this in the latest patch. I refactored 'branchName' to be 'branches', changed the type of the variable to be an array, and updated the code that interacts with it accordingly.

> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:172
> > +        var gitBranches = doc.evaluate("./branches", commitElement, null, XPathResult.STRING_TYPE).stringValue;
> > +        if (gitBranches) {
> > +            result.containsBranchLocation = true;
> > +            result.branchName = gitBranches.split(", ");
> > +        }
> 
> We need a test case for a multi-branch commit.

I added a test case and corresponding assertions for a multi-branch commit.

> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js:60
> > +    strictEqual(commits.length, 6, "should have 6 commits");
> 
> It's weird that there are six commits because on first glance this test only
> parses a single commit. I know that five of these commits are hardcoded in
> class MockTrac. Can we extract the hardcoded recorded commits from MockTrac
> into some kind of constant, maybe MockTrac.EXAMPLE_TRAC_COMMITS, such that
> MockTrac has no recorded commits by default? Unit tests that want to make
> use of this set of mock commits could then set MockTrac.recordedCommits =
> MockTrac.EXAMPLE_TRAC_COMMITS. And we would not make use of this set of
> commits for this test.

I did this in the latest patch as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160201/9d8a4487/attachment.html>