[Webkit-unassigned] [Bug 153741] REGRESSION(r195899): ASSERTION FAILED: is<Target>(source) in EventPath::retargetTouch() since r195899

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 1 09:27:55 PST 2016


--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #3)
> (In reply to comment #2)
> > Comment on attachment 270384 [details]
> > Fix an EventContext downcast.
> > 
> > I didn't look closely at this, but I'm suspicious that there is a downcast
> > there if the result of the downcast can be changed without breaking the
> > build....
> MouseOrFocusEventContext also derives from EventContext, so the cast is
> valid form the compiler point of view. That's why we have the type traits
> thing to check the cast is valid at runtime. It ended up calling
> EventContext::isMouseOrFocusEventContext() that return false, because the
> concrete type in this case is TouchEventContext.

But it's true that we are using EventContext::node(), and *m_path[0] is already an EventContext, so we don't even need the downcast, I would say.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160201/4720ed13/attachment-0001.html>

More information about the webkit-unassigned mailing list