[Webkit-unassigned] [Bug 166455] New: [GTK] GLES build broken since r208997

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=166455

            Bug ID: 166455
           Summary: [GTK] GLES build broken since r208997
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at igalia.com
                CC: achristensen at apple.com, bugs-noreply at webkitgtk.org,
                    magomez at igalia.com

GLES build is broken since r208997 (bug #164049). I don't normally ask for reviews for simple build failures, but I'm not sure about the right preprocessor guards to use here. Extensions3DOpenGLCommon::initializeAvailableExtensions currently guards its use of API not available in GLES2 with #if PLATFORM(MAC) || PLATFORM(GTK), which isn't good enough. At first I thought to change it to #if PLATFORM(MAC) || (PLATFORM(GTK) && !USE(OPENGL_ES_2)), but actually this code does not appear to be platform-specific, so maybe we can just use #if !USE(OPENGL_ES_2) here? Let's try that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161223/c1f9ceaa/attachment-0001.html>