[Webkit-unassigned] [Bug 166331] New: webkit-test-runner options aren't recognised with HTTP tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=166331

            Bug ID: 166331
           Summary: webkit-test-runner options aren't recognised with HTTP
                    tests
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: graouts at apple.com
                CC: lforschler at apple.com

Using a comment like <!-- webkit-test-runner [ enableModernMediaControls=false ] --> at the top of a test should disable modern media controls for a given test. This works well with tests there file: URLs, but not with http: URLs, such as any of the tests under http/. I've traced the problem to `static std::string testPath(WKURLRef url)` which only knows how to deal with file: URLs and returns an empty string otherwise, which means that test options aren't parsed due to returning early in updateTestOptionsFromTestHeader() if filename.empty().

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161221/38a8d6cf/attachment.html>