[Webkit-unassigned] [Bug 166047] Macro expansion producing 'defined' has undefined behavior

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=166047

--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 297493
  --> https://bugs.webkit.org/attachment.cgi?id=297493
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297493&action=review

>> Source/JavaScriptCore/runtime/JSGlobalObject.h:302
>> +#if JSC_OBJC_API_ENABLED == 1
> 
> This is not the normal pattern for how we test for things being enabled, and thus it's error prone. Why was this part of the fix necessary?

== 1 is definitely not what we want here

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161220/3d9517b3/attachment.html>