[Webkit-unassigned] [Bug 159398] [test262] Fixing mapped arguments object property test case

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 20 09:24:58 PST 2016


https://bugs.webkit.org/show_bug.cgi?id=159398

--- Comment #85 from Caio Lima <ticaiolima at gmail.com> ---
Comment on attachment 297500
  --> https://bugs.webkit.org/attachment.cgi?id=297500
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297500&action=review

>> Source/JavaScriptCore/runtime/GenericArgumentsInlines.h:70
>> +    bool result = Base::getOwnPropertySlot(thisObject, exec, ident, slot);
> 
> Is this just to get the attributes?

Yes! Do you think that there is another way to get them?

>> Source/JavaScriptCore/runtime/GenericArgumentsInlines.h:234
>> +            if (thisObject->isMappedArgument(optionalIndex.value())) {
> 
> Nit: you can just use index since it's defined above.

Nice catch. Thx!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161220/c87a9c32/attachment.html>


More information about the webkit-unassigned mailing list