[Webkit-unassigned] [Bug 165119] Add coordinate space to event streams and streamline tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 15 16:17:36 PST 2016


https://bugs.webkit.org/show_bug.cgi?id=165119

--- Comment #9 from Tim Horton <thorton at apple.com> ---
Comment on attachment 297219
  --> https://bugs.webkit.org/attachment.cgi?id=297219
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297219&action=review

> Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:73
> +    //          //This is a basic force press

Comments have spaces after the //

> Tools/WebKitTestRunner/ios/HIDEventGenerator.h:54
> +// Values for

Values for what?

> Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:223
> +    auto eventInfo = dynamic_objc_cast<NSDictionary>([NSJSONSerialization JSONObjectWithData:[(NSString *)jsonString dataUsingEncoding:NSUTF8StringEncoding] options:NSJSONReadingMutableContainers |NSJSONReadingMutableLeaves error:nil]);

Space after the |

> LayoutTests/fast/events/touch/ios/long-press-then-drag-down-to-change-selected-text.html:82
> +                    testRunner.runUIScript(getDragScript(72,120,72,140), function(result) {

Spaces after commas

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161216/d4bd8945/attachment-0001.html>


More information about the webkit-unassigned mailing list