[Webkit-unassigned] [Bug 165793] [GStreamer] use FastMalloc-based GstAllocator

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=165793

--- Comment #3 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 296994
  --> https://bugs.webkit.org/attachment.cgi?id=296994
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=296994&action=review

>> Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp:161
>> +        fprintf(stderr, "initializeGStreamer(): using FastMalloc allocator %p\n", allocator);
> 
> I would GST_INFO this, though it would require to add a debug category for this.

It's a debugging leftover, can be removed.

>> Source/WebCore/platform/graphics/gstreamer/GstAllocatorFastMalloc.cpp:36
>> +    auto* mem = reinterpret_cast<GstMemoryFastMalloc*>(fastAlignedMalloc(alignment + 1, headerSize + allocationSize));
> 
> I prefer typed things when they are non-trivial, which IMHO is  the case.

This is typed like anything else, but it removes the duplicated information.

Also, static_cast<> can be used.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161213/2e6b21df/attachment.html>