[Webkit-unassigned] [Bug 165755] New: webkitDisplayingFullscreen may return false in webkitfullscreenchange event handler

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 12 06:44:26 PST 2016


https://bugs.webkit.org/show_bug.cgi?id=165755

            Bug ID: 165755
           Summary: webkitDisplayingFullscreen may return false in
                    webkitfullscreenchange event handler
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Media Elements
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: graouts at apple.com

The test at media/modern-media-controls/fullscreen-support/fullscreen-support-click.html is flaky, try running it as follows:

Tools/Scripts/run-webkit-tests --release --time-out-ms=5000 --no-sample-on-timeout --exit-after-n-failures=1 --iterations=200 media/modern-media-controls/fullscreen-support/fullscreen-support-click.html

When it fails, you can see that the cause is that media.webkitDisplayingFullscreen returns false whereas it should return true. By deferring the assertion to the next run loop, the test never fails:

media.addEventListener("webkitfullscreenchange", () => {
    // We use a timeout here as sometimes media.webkitDisplayingFullscreen
    // wouldn't return true just yet after entering fullscreen.
    setTimeout(() => {
        shouldBeTrue("media.webkitDisplayingFullscreen");
        container.remove();
        media.remove();
        finishJSTest();
    });
});

While I can work around this to fix this test, we should find what the root cause for this is.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161212/c5927d8f/attachment.html>


More information about the webkit-unassigned mailing list