[Webkit-unassigned] [Bug 165506] Inspector::InspectorValue class doesn't handle undefined type

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=165506

Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #296567|review?                     |review+
              Flags|                            |

--- Comment #8 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 296567
  --> https://bugs.webkit.org/attachment.cgi?id=296567
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296567&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        * bindings/ScriptValue.cpp:
> +        (Inspector::jsToInspectorValue):

We should include a description here about why. Something like:

It is okay to turn undefined into null because we are producing values for a
JSON representation (InspectorValue) and JSON has a `null` value and no
`undefined` value.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161208/e2edb6f6/attachment.html>