[Webkit-unassigned] [Bug 165506] Inspector::InspectorValue class doesn't handle undefined type

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=165506

--- Comment #3 from Karim <karim at karhm.com> ---
There is a FIXME tag at:JavaScriptCore/bindings/ScriptValue.cpp:56
// FIXME: Why is it OK to turn undefined into null?

> Comment on attachment 296360 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=296360&action=review
> 
> > Source/JavaScriptCore/ChangeLog:4
> > +        Added undefined type and fixed related issues
> > +        https://bugs.webkit.org/show_bug.cgi?id=165506
> 
> "undefined" is not a valid JSON value type:
> http://www.json.org
> http://www.ecma-international.org/publications/files/ECMA-ST/ECMA-404.pdf
> 
> >>> JSON.stringify({a:undefined})
> {}
> 
> >>> JSON.stringify({a:null})
> {"a":null}
> 
> Is there a specific reason we want to be adding it to InspectorValues?
> 
> > Source/JavaScriptCore/ChangeLog:11
> > +        * runtime/VM.h:
> 
> This looks stale, the diff doesn't show any modifications to VM.h.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161208/24849961/attachment.html>