[Webkit-unassigned] [Bug 165502] [iOS] WKWebView should not allow app links to be opened on back or forward navigation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=165502

--- Comment #5 from mitz at webkit.org <mitz at webkit.org> ---
(In reply to comment #4)
> Comment on attachment 296357 [details]
> Patch (with style fixed) for [iOS] WKWebView should not allow app links to
> be opened on back or forward navigation
> 
> I wonder if a better way to do this would be to update
> API::NavigationAction::shouldOpenAppLinks() to check that navigationType is
> not NavigationType::BackForward.  I'm actually not sure, Dan?

That’s possible, but that would be encoding (admittedly trivial) policy logic into what is currently a data container. I think, however, that WebPageProxy::decidePolicyForNavigationAction, which is where we currently initialize the NavigationAction, would be a good place to implement this policy. I agree that setting the m_shouldSuppressAppLinksInNextNavigationPolicyDecision in advance is unnecessarily complex and fragile.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161207/ef9a8ffa/attachment.html>