[Webkit-unassigned] [Bug 165246] [GTK] Fails to draw in Wayland with enabled compositing mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=165246

--- Comment #6 from Milan Crha <mcrha at redhat.com> ---
I second your feelings. I'm afraid that we even would lose users due to them thinking that the evolution is completely broken, while it would be hard to explain that it's not only the evolution, but anything what uses webKit2, and then you telling them it's not about WebKit2 (partly), but about their drivers. Phew, I can imagine what they would think about all of us...

Thus, if you can, please disable composite rendering by default in 2.14.3 and let's hope that distros which tend not to update their packages that often will pick such important change too. (/me crosses fingers)

I would suggest to change the related code, the one where you check for WEBKIT_DISABLE_COMPOSITING_MODE, to not test only existence, but to test also the value, which would look like:

   const gchar *value = g_getenv ("WEBKIT_DISABLE_COMPOSITING_MODE");
   if (!value) {
      // disable compositing mode
      // disable the force something, what preceded with the other env
      //     variable or being forced by a compiler switch (#define)
   } else if (g_strcmp0 (value, "1") == 0) {
      // disable compositing mode
   } else {
      // enable compositing mode
   }

If a user would use "WEBKIT_DISABLE_COMPOSITING_MODE=blabla" then it's his/her fault, as the value will be expected "0" or "1", where "0" (anything but "1") enables compositing mode.

Ideally if you also add relevant APIs to override the state for the applications, without the need to modify environment variables.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161206/ddc219b2/attachment.html>