[Webkit-unassigned] [Bug 161276] AX: Crash at AccessibilityRenderObject::computeAccessibilityIsIgnored const + 552

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=161276

--- Comment #5 from Nan Wang <n_wang at apple.com> ---
Comment on attachment 287168
  --> https://bugs.webkit.org/attachment.cgi?id=287168
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287168&action=review

>>> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1158
>>> +    RenderObject* protectedRenderer(m_renderer);
>> 
>> does this hold onto the object? or just make a copy of the pointer?
> 
> Good point, I'll double check. The RenderObject is not ref counted.

Since m_renderer is just a raw pointer, we have no way to know anything about the ownership and hold onto it easily (I did a lot of searches on smart pointers but I don't think we want to declare sole ownership within this function). A copy of the RenderObject might work but I suspect it will affect the performance quite a lot. The easiest way I can think of (since we are not sure what is causing the m_renderer being null) is to null check at all the place within this function when we are accessing m_renderer, but that seems to be very ugly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160830/de7eb1cc/attachment.html>