[Webkit-unassigned] [Bug 161215] charactersAroundPosition can be wrong because it crosses editing boundaries
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 25 19:33:24 PDT 2016
https://bugs.webkit.org/show_bug.cgi?id=161215
Ryosuke Niwa <rniwa at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #287027|review? |review+
Flags| |
--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 287027
--> https://bugs.webkit.org/attachment.cgi?id=287027
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=287027&action=review
It looks like fast/dom/focus-contenteditable.html is failing on WebKit2. Please check that before landing it.
> Source/WebCore/ChangeLog:5
> + -and corresponding-
I don't think we need this line.
> Source/WebCore/ChangeLog:14
> + VisiblePosition::previous().
> + * editing/VisibleUnits.cpp:
We need a blank line here.
> LayoutTests/editing/mac/spelling/accept-candidate-without-crossing-editing-boundary.html:3
> +<script src=../../editing.js language="javascript" type="text/javascript"></script>
We don't need language & type attributes.
> LayoutTests/editing/mac/spelling/accept-candidate-without-crossing-editing-boundary.html:10
> + var s = window.getSelection();
It looks like this variable is never used.
> LayoutTests/editing/mac/spelling/accept-candidate-without-crossing-editing-boundary.html:32
> +<div style="visibility:hidden;">
> + <br>
> +</div>
> +
> +<div style="width: 1px; height: 1px;"></div>
Do we really need these stray elements?
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160826/b5277eba/attachment.html>
More information about the webkit-unassigned
mailing list