[Webkit-unassigned] [Bug 161149] New: [GTK] run-gtk-tests should use the driver environment for checking the accessibility bus

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=161149

            Bug ID: 161149
           Summary: [GTK] run-gtk-tests should use the driver environment
                    for checking the accessibility bus
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: clopez at igalia.com
                CC: bugs-noreply at webkitgtk.org, cgarcia at igalia.com,
                    lforschler at apple.com
            Blocks: 160736

Currently run-gtk-tests waits for the accessibility bus on D-Bus to appear like this:

        # We need to wait until the SPI bus is launched before trying to start the SPI
        # registry, so we spin a main loop until the bus name appears on DBus.
        loop = GLib.MainLoop()
        Gio.bus_watch_name(Gio.BusType.SESSION, 'org.a11y.Bus', Gio.BusNameWatcherFlags.NONE,
                           lambda *args: loop.quit(), None)
        loop.run()


The problems are:

 1) It runs the check using the environment from the user rather than the environ that should be used for the tests. So the environment variables from the driver (after bug 160736) are not correctly set (like DISPLAY or WAYLAND_DISPLAY). This seems to be somehow relevant, because if the system don't has the environment variable DBUS_SESSION_BUS_ADDRESS defined, dbus is able to do the right thing if at least DISPLAY is set to the correct value. Otherwise it fails.

 2) It don't has a timeout. In case the accessibility bus don't appears, it hangs forever.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160824/aa5381ab/attachment-0001.html>