[Webkit-unassigned] [Bug 154808] NewRegexp should not prevent inlining

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 22 23:41:40 PDT 2016


--- Comment #8 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 286601
  --> https://bugs.webkit.org/attachment.cgi?id=286601

You shouldn't be adding any new fields to CodeBlock. 

The DFG already has a mechanism for strongly marking objects known to the compiler such as the RegExps. It's called freezing: just do m_graph.freezeStrongly(...). 

You don't need to record the RegExp object anywhere other than the NewRegExp node. That node should not have an index into any vectors. It should just hold a pointer to RegExp. We already do this for other node types. See for example Node::cellOperand(). Notice that its already compatible with freezing.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160823/3d30ae61/attachment.html>

More information about the webkit-unassigned mailing list