[Webkit-unassigned] [Bug 160981] AX: iOS, Wrong axLabel on static text if heading has multiple children

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 19 09:01:00 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=160981

--- Comment #5 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 286414
  --> https://bugs.webkit.org/attachment.cgi?id=286414
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286414&action=review

> Source/WebCore/ChangeLog:9
> +        no alternate texts. So we shouldn't use accessibilityLable to check for user defined texts

no alternate "text." - text is already plural here

accessibilityLable -> accessibilityLabel

this description isn't very clear to me... what is the problem with calling axLabel? what does it return, that baseDescription does not

> LayoutTests/accessibility/ios-simulator/heading-with-aria-label.html:40
> +        // Also make sure when the heading has multiple children, we are not messing up with

"messing up" is too colloquial here. I would say

"When a heading has multiple children, ensure ..."

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160819/9cd73320/attachment.html>


More information about the webkit-unassigned mailing list