[Webkit-unassigned] [Bug 160709] Move functionality common to Darwin ports into a base class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=160709

--- Comment #5 from Jonathan Bedard <jbedard at apple.com> ---
(In reply to comment #4)
> Comment on attachment 285675 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=285675&action=review
....
> 
> > Tools/Scripts/webkitpy/port/darwin.py:199
> > +    def xcrun_find(self, command, fallback):
> > +        _log.warn("xcrun undefined; falling back to '%s'." % fallback)
> > +        return fallback
> 
> This does not seem correct. We can and should make use of xcrun to find
> command line tools for both the Mac and iOS ports.

We do use xcrun for both Mac and iOS, but iOS assumes it's being run through a simulator, so it has a few extra arguments.  ios.py line 400 has the iOS simulator xcrun.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160818/fa1a3f0c/attachment.html>