[Webkit-unassigned] [Bug 160904] Use find_library within Windows build

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=160904

Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #286250|                            |review+
              Flags|                            |

--- Comment #11 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 286250
  --> https://bugs.webkit.org/attachment.cgi?id=286250
FindICU with comments

View in context: https://bugs.webkit.org/attachment.cgi?id=286250&action=review

I can confirm that this patch builds properly on a local Windows development machine. The build failure was due to an existing WIndows problem that has since been fixed.

Note that we need to land Bug 160949 before this one.

> Source/cmake/FindICU.cmake:82
> +        set(ICU_DATA_LIBRARIES)

I wonder if set(ICU_DATA_LIBRARIES ${ICU_DATA_LIBRARY}) just does the right thing in the case of no ICU_DATA_LIBRARY value...

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160817/deee5f35/attachment.html>