[Webkit-unassigned] [Bug 160904] Use find_library within Windows build

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=160904

--- Comment #1 from Don Olmstead <don.olmstead at am.sony.com> ---
On Windows WebKitLibraries/win is the root for third party libraries in the project. In CMake the WEBKIT_LIBRARIES_DIR is set for this. So within FindICU.cmake you can do the following which allows Windows to find it.

find_path(
    ICU_INCLUDE_DIR
    NAMES unicode/utypes.h
    HINTS ${PC_ICU_INCLUDE_DIRS}
          ${PC_ICU_INCLUDEDIR}
          ${WEBKIT_LIBRARIES_DIR}/include
    DOC "Include directory for the ICU library")
mark_as_advanced(ICU_INCLUDE_DIR)

One thing I'm wondering however is should the be a WEBKIT_LIBRARIES_ROOT and then some variables around that be added. So WEBKIT_LIBRARIES_INCLUDE_DIR/WEBKIT_LIBRARIES_LINKER_DIR which would then be used within the HINTS section.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160816/f9caa462/attachment.html>