[Webkit-unassigned] [Bug 160808] FocusController multiple dereferenced NULL pointers

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 12 13:07:35 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=160808

--- Comment #4 from Jonathan Bedard <jbedard at apple.com> ---
Here are the two places where the behavior has been observed:

.../FocusController.cpp:672:80: runtime error: reference binding to null pointer of type 'WebCore::KeyboardEvent'
.../FocusController.cpp:586:53: runtime error: reference binding to null pointer of type 'WebCore::KeyboardEvent'

The motivation for this change is that while we check if the Elements are NULL, we basically never do so for the KeyBoardEvents.  Even just a quick overview will show that lines 507, 509, 520, 543, 558, 564, 647, 694, 952 and 704 all have this same problem (note that those line numbers are in the unedited version).  It is true that the Elements are already checked, I thought that the static functions should either both be references or both be pointers, which is why I switched Element references to pointers as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160812/81f167ae/attachment-0001.html>


More information about the webkit-unassigned mailing list