[Webkit-unassigned] [Bug 159827] run-webkit-tests should trigger a spindump when WebContent process is unresponsive

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=159827

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #285383|commit-queue?               |commit-queue+
              Flags|                            |

--- Comment #59 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 285383
  --> https://bugs.webkit.org/attachment.cgi?id=285383
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285383&action=review

> Tools/WebKitTestRunner/TestInvocation.cpp:193
> -    char errorMessageToStderr[1024];
> +    char buffer[1024] = { };

I do not think that initializing the buffer is an improvement over existing code. This doesn't make it any safer.

> Tools/WebKitTestRunner/TestInvocation.cpp:210
> +        fprintf(stderr, "Failed receive expected sample response, got:\n\t\"%s\"\nContinuing...\n", buffer);

Not sure if this is proper English. "Failed to receive" maybe?

Also, won't the error get printed in interactive mode every time? That would be misleading.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160808/bf257548/attachment.html>