[Webkit-unassigned] [Bug 160658] New: [GTK] webkit_web_context_set_tls_errors_policy fails when called before network process is created

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=160658

            Bug ID: 160658
           Summary: [GTK] webkit_web_context_set_tls_errors_policy fails
                    when called before network process is created
    Classification: Unclassified
           Product: WebKit
           Version: Other
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Minor
          Priority: P2
         Component: WebKit Gtk
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at igalia.com
                CC: bugs-noreply at webkitgtk.org

In webkitWebContextConstructed we have this code:

    priv->processPool = WebProcessPool::create(configuration);

    // ...

    priv->tlsErrorsPolicy = WEBKIT_TLS_ERRORS_POLICY_FAIL;
    priv->processPool->setIgnoreTLSErrors(false);

The call to WebProcessPool::setIgnoreTLSErrors always fails, because it only sends the message if the network process has already been created, but at this point it has not been created yet.

I think it's not really needed here, because false is the default, so not a big deal. But it becomes a real problem if an API user ever does something like this:

    context = webkit_web_context_new();
    webkit_web_context_set_tls_errors_policy (context, WEBKIT_TLS_ERRORS_POLICY_IGNORE);

This fails too, the policy gets changed in the UI process, but the network process never sees it. I don't think these messages should ever be dropped.

As suggested by Nick White in bug #128674, an appropriate fix might be for WebProcessPool::setIgnoreTLSErrors to call ensureNetworkProcess().

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160808/af9a63f7/attachment-0001.html>