[Webkit-unassigned] [Bug 160362] NULL Reference Error in ElementRuleCollector

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 5 11:37:30 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=160362

--- Comment #13 from Jonathan Bedard <jbedard at apple.com> ---
I think what is happening here (although I am by no means an expert in CSS) is that if the author style is undefined for a particular element, it adopts the author style of the entire page.  However, if it tries to access the author style before adapting the author style of the page (which really shouldn't happen) then it will be accessing a NULL pointer.  As far as I can tell, what is happening in this case is the ElementRuleCollector is being instantiated before this adoption happens and then either being re-instantiated after or never using the bound NULL reference (although the behavior of the the two newly passing tests may indicate that in some circumstances ElementRuleCollector was using the NULL reference)

What this comes down to is that the old code made two competing assumptions: that the author style would never be NULL when accessed and that the author style could be NULL and would need to instantiated with the author style of the page when it was.  I'm not sure which assumption is correct.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160805/0a7ac679/attachment.html>


More information about the webkit-unassigned mailing list