[Webkit-unassigned] [Bug 160598] New: page/Chrome.cpp: Add ASSERT(frame) to catch nulls and eventually change frame from pointer to reference

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=160598

            Bug ID: 160598
           Summary: page/Chrome.cpp: Add ASSERT(frame) to catch nulls and
                    eventually change frame from pointer to reference
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: wilander at apple.com

Brent Fulgham pointed the following out regarding page/Chrome.cpp:

It looks like frame is assumed to be non-null most places it is used. We should probably make it a reference in a future patch to help enforce this. I think we should add an "ASSERT(frame)" so we can catch cases where this assumption is not true.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160805/55d41af0/attachment.html>