[Webkit-unassigned] [Bug 160497] MemoryPressureHandler shouldn't know how to release WebCore memory

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 5 07:40:46 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=160497

--- Comment #2 from Andreas Kling <akling at apple.com> ---
Comment on attachment 285219
  --> https://bugs.webkit.org/attachment.cgi?id=285219
WIP patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285219&action=review

This is quite nice :)

> Source/WebKit/mac/WebView/WebView.mm:1127
> +        notify_register_dispatch("com.apple.WebKit.fullGC", &dummy, dispatch_get_main_queue(), ^(int) {
> +            GCController::singleton().garbageCollectNow();
> +        });
> +        notify_register_dispatch("com.apple.WebKit.deleteAllCode", &dummy, dispatch_get_main_queue(), ^(int) {
> +            GCController::singleton().deleteAllCode();
> +            GCController::singleton().garbageCollectNow();
> +        });

This code is duplicated in both WebKit1 and WebKit2. If a process uses both, it will hook 2 separate callbacks to each notification name, effectively making the callbacks execute twice.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160805/b2ef3e80/attachment-0001.html>


More information about the webkit-unassigned mailing list