[Webkit-unassigned] [Bug 160552] handleErrorPages() is not supported by TestRunner, remove dependent test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 4 17:44:09 PDT 2016


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #285331|review?                     |review-
              Flags|                            |

--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 285331
  --> https://bugs.webkit.org/attachment.cgi?id=285331

View in context: https://bugs.webkit.org/attachment.cgi?id=285331&action=review

The motivation for this change seems reasonable. We need to also update file LayoutTests/platform/ios-simulator/TestExpectations. Also we should update the ChangeLog entry such that it list the files modified in this patch as well as clarify the description as per my remarks above.

> LayoutTests/ChangeLog:10
> +
> +        Removed fast/history/back-forward-reset-after-error-handling.html and all
> +        references since handleErrorPages() was never supported in TestRunners
> +

How are you generating this ChangeLog entry? Please use prepare-ChangeLog to generate the ChangeLog message.

It is disingenuous to write "was never supported in TestRunners". We should explain that window.testRunner.handleErrorPages() was only implement for the Qt WebKit port and that there has not been interest to implement this feature in any other port in the over 7 years since this feature was added.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160805/764c2192/attachment.html>

More information about the webkit-unassigned mailing list