[Webkit-unassigned] [Bug 159827] run-webkit-tests should trigger a spindump when WebContent process is unresponsive

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=159827

Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #285370|review?                     |review-
              Flags|                            |

--- Comment #56 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 285370
  --> https://bugs.webkit.org/attachment.cgi?id=285370
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285370&action=review

We should add tests to ensure that we only call sample() if spindump returns a non-zero exit status. We should use the test test_sample_process_throws_exception as an example for how to substitute a custom function for Executive.run_command().

> Tools/Scripts/webkitpy/port/mac_unittest.py:-224
> -    def test_sample_process_throws_exception(self):
> -
> -        def throwing_run_command(args):
> -            raise ScriptError("MOCK script error")
> -
> -        port = self.make_port()
> -        port._executive = MockExecutive2(run_command_fn=throwing_run_command)
> -        OutputCapture().assert_outputs(self, port.sample_process, args=['test', 42])
> -

We shouldn't remove this test. We should make this test work with the proposed code changes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160804/cfeab00e/attachment.html>