[Webkit-unassigned] [Bug 160465] Web Inspector: CodeMirror in resource content view should not show 'CR' characters

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 2 15:39:33 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=160465

--- Comment #4 from Nikita Vasilyev <nvasilyev at apple.com> ---
(In reply to comment #3)
> I don't think editing codemirror.js is going to be the right fix. Here are
> some alternatives:
> 
> 1. Heuristically detect whether the line endings seem to be \r\n or \n and
> tell CodeMirror which line ending to assume (there's a setting for that)

This is what Chrome seems to do.
https://codereview.chromium.org/19540026/

> 2. Strip line endings from the text that we display (somewhat dangerous due
> to line:col interactions with JSC)
> 3. Tag the CR character with CSS and make it visibility:none.

I can't figure out how to write a valid CSS selector for this element:

<span class="cm-invalidchar" cm-text="
">␍</span>

These don't work:

.cm-invalidchar[cm-text="
"]
.cm-invalidchar[cm-text="\n"]
.cm-invalidchar[cm-text="\a"]

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160802/ac8988de/attachment.html>


More information about the webkit-unassigned mailing list