[Webkit-unassigned] [Bug 157219] AX: @aria-label attribute should work on <label> element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=157219

--- Comment #2 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 277769
  --> https://bugs.webkit.org/attachment.cgi?id=277769
initial patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277769&action=review

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1269
> +            // If there's aria-label on the label, we should use it instead.

this comment seems unnecessary, since its self evident from the code

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1270
> +            const AtomicString& labelStr = labelObject->getAttribute(aria_labelAttr);

const AtomicString& ariaLabel

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1075
> +    // otherwise its inner text will be announced by screenreader.

announced by "a" screenrea

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160430/89686caf/attachment.html>