[Webkit-unassigned] [Bug 157133] Move ResourceTiming behind a runtime flag

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 28 21:16:37 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=157133

Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #277648|review?                     |review+
              Flags|                            |

--- Comment #11 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 277648
  --> https://bugs.webkit.org/attachment.cgi?id=277648
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277648&action=review

> Source/WebCore/loader/cache/CachedResourceLoader.cpp:79
>  #include "Performance.h"

This should go up with the other includes.

> Source/WebCore/page/Performance.h:69
> +    PassRefPtr<PerformanceEntryList> getEntries() const;
> +    PassRefPtr<PerformanceEntryList> getEntriesByType(const String& entryType);
> +    PassRefPtr<PerformanceEntryList> getEntriesByName(const String& name, const String& entryType);

Not necessary to return PassRefPtr.  Can just be RefPtr, or we could do that in another patch.  We're trying to get rid of PassRefPtr.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160429/53dcffbe/attachment.html>


More information about the webkit-unassigned mailing list