[Webkit-unassigned] [Bug 157066] REGRESSION(r200094): [FreeType] Vertical text is broken after r200094

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 27 09:20:05 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=157066

--- Comment #13 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #11)
> (In reply to comment #10)
> > Comment on attachment 277470 [details]
> > Try to fix EFL build
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=277470&action=review
> > 
> > >> Source/WebCore/platform/graphics/cairo/CairoUtilities.h:64
> > >> +};
> > > 
> > > One note is that by not putting the implementation of the constructor and destructor here, it is impossible for the compiler to inline them. It might be better to avoid changing that.
> > 
> > I don’t think that’s right. Why wouldn’t the compiler inline them?
> 
> I thought that the compiler was unable to inline code across compilation
> units, but I could very well be wrong about that.

I can move the implementation to the header in any case to be extra sure.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160427/377932a9/attachment.html>


More information about the webkit-unassigned mailing list